jamesfredley commented on code in PR #14708:
URL: https://github.com/apache/grails-core/pull/14708#discussion_r2072307791
##########
gradle/assemble-root-config.gradle:
##########
@@ -116,8 +116,7 @@ tasks.register('assemble', Zip).configure {
into("grails-$grailsVersion") {
from(rootProject.layout.projectDirectory) {
- // Some of these are probably not needed as they are not present
in the project folder
- include 'bin/grails', 'bin/grails.bat', 'lib/', 'media/',
'samples/', 'scripts/', 'LICENSE', 'INSTALL'
+ include 'bin/grails', 'bin/grails.bat', 'lib/',
'media/icons/grails.icns', 'LICENSE', 'INSTALL'
Review Comment:
The notice file can be added.
https://github.com/apache/grails-core/blob/9794089e793c642790cb2b90f51e66727c726781/gradle/assemble-root-config.gradle#L64
is the only file being used from /media
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
