jamesfredley commented on code in PR #14708:
URL: https://github.com/apache/grails-core/pull/14708#discussion_r2072312457
##########
grails-shell-cli/src/main/groovy/org/grails/cli/GrailsCli.groovy:
##########
@@ -507,12 +507,7 @@ class GrailsCli {
private initializeProfile() {
BuildSettings.TARGET_DIR?.mkdirs()
- if(!new File(BuildSettings.BASE_DIR, "profile.yml").exists()) {
- populateContextLoader()
- }
- else {
- this.profileRepository = createMavenProfileRepository()
- }
+ this.profileRepository = createMavenProfileRepository()
Review Comment:
I believe that is `~/.grails/settings.groovy`
https://github.com/apache/grails-core/blob/9fef7c0f3269d10998439e1eed2bb564020840fb/grails-shell-cli/src/main/groovy/org/grails/cli/GrailsCli.groovy#L83
This removed code was only running when wrapper or shell-cli and failed to
correctly lookup the active profile. Given how flakey it was and the repeated
trouble it created, simplifying this code seemed like the right path forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
