SYaoJun commented on PR #904: URL: https://github.com/apache/incubator-graphar/pull/904#issuecomment-4198628851
> This change introduces `cmake-format` checks and also updates CMake-related files outside `cpp/`, such as `python/CMakeLists.txt`, `maven-projects/java/CMakeLists.txt`, `.pre-commit-config.yaml`, and `cmake-format.py`. However, the workflow trigger in `.github/workflows/ci.yml` still only watches `cpp/**` and the workflow file itself. > > As a result, future PRs that only modify those non-`cpp/` CMake/config files will not trigger this workflow, so the new `cmake-format` check will not run for them. That means the formatting rule is not fully enforced by CI and can silently drift or break. > > I think the workflow `paths` filter should be expanded to include the newly covered files and directories. Hi @Thespica, I create a new `pre-commit.yml` to check all the format issue, which does not limit to cpp directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
