justinmclean opened a new issue, #8035:
URL: https://github.com/apache/gravitino/issues/8035

   ### What would you like to be improved?
   
   In 
catalogs/catalog-jdbc-common/src/test/java/org/apache/gravitino/catalog/jdbc/operation/SqliteTableOperations.java,
 correct SQLite table creation SQL generation to always close with a semicolon 
and include optional comments and properties to prevent malformed statements 
when a comment is specified.
   
   Here's a test to help:
   ```
     @Test
     public void testGenerateCreateTableSqlWithCommentEndsWithSemicolon() {
       SqliteTableOperations ops = new SqliteTableOperations();
       
       String sql = ops.generateCreateTableSql(
           "test_table",
           new JdbcColumn[0],
           "comment",
           null,
           new Transform[0],
           Distributions.NONE,
           new Index[0]);
       
       assertTrue(sql.trim().endsWith("COMMENT 'comment';"), 
                  "Generated SQL should end with COMMENT 'comment';");
     }
   ```
   
   
   ### How should we improve?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to