hqbhoho commented on code in PR #7820:
URL: https://github.com/apache/gravitino/pull/7820#discussion_r2275050098
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -126,6 +127,9 @@ public class GravitinoConfig {
"false",
false);
+ private static final ConfigEntry GRAVITINO_CLIENT_CONFIG_PREFIX =
+ new ConfigEntry("gravitino.client.", "The config prefix for Grivitino
client", "", false);
+
Review Comment:
I think a config prefix is better, otherwise, if adding a new parameter in
the Java client, the Trino connector would need to add a configuration for
every single new parameter.
Currently, it requires no code modification here to automatically use new
Java client conig. Other connector or gvfs all use config prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
