diqiu50 commented on code in PR #7820:
URL: https://github.com/apache/gravitino/pull/7820#discussion_r2271914111
##########
trino-connector/trino-connector/src/test/java/org/apache/gravitino/trino/connector/TestGravitinoConfig.java:
##########
@@ -84,4 +87,43 @@ public void
testGravitinoConfigWithSkipTrinoVersionValidation() {
assertEquals(configWithSkipValidation.isSkipTrinoVersionValidation(),
true);
}
+
+ @Test
+ public void testGravitinoConfigWithClientConfig() {
+ String gravitinoUrl = "http://127.0.0.1:8000";;
+ String metalake = "user_001";
+ ImmutableMap<String, String> configMap =
+ ImmutableMap.of("gravitino.uri", gravitinoUrl, "gravitino.metalake",
metalake);
+ GravitinoConfig config = new GravitinoConfig(configMap);
+
+ assertTrue(config.getClientConfig().isEmpty());
+
+ ImmutableMap<String, String> configMapWithClientConfig =
+ ImmutableMap.of(
+ "gravitino.uri",
+ gravitinoUrl,
+ "gravitino.metalake",
+ metalake,
+ "gravitino.client.config",
+ "gravitino.client.socketTimeoutMs=10000,
gravitino.client.connectionTimeoutMs = 20000 ");
+ GravitinoConfig configWithClientConfig = new
GravitinoConfig(configMapWithClientConfig);
+ Map<String, String> clientConfig =
configWithClientConfig.getClientConfig();
+ assertEquals(clientConfig.get("gravitino.client.socketTimeoutMs"),
"10000");
+ assertEquals(clientConfig.get("gravitino.client.connectionTimeoutMs"),
"20000");
+
+ ImmutableMap<String, String> configMapWithInvalidClientConfig =
+ ImmutableMap.of(
+ "gravitino.uri",
+ gravitinoUrl,
+ "gravitino.metalake",
+ metalake,
+ "gravitino.client.config",
+ "gravitino.client.socketTimeoutMs,
gravitino.client.connectionTimeoutMs = 20000 ");
Review Comment:
I think it is not good to write the configuration as a single string here.
It is more appropriate to flatten it out and use multiple configuration items
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
