Pranaykarvi commented on PR #9590: URL: https://github.com/apache/gravitino/pull/9590#issuecomment-3722256619
> > Hi @FANNG1, > > I’ve applied Spotless formatting cleanly to align with CI (spotlessJavaCheck). Logic is unchanged; this commit is formatting-only. > > Thanks for your patience could you please take another look? > > After investigating how Flink handles serde-lib in https://github.com/apache/flink/blob/b2a260ac957dac3b6af5dc73684624dd36dc92ea/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java#L502 and https://github.com/apache/flink/blob/b2a260ac957dac3b6af5dc73684624dd36dc92ea/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java#L508 Summarize the logic as follows, please correct me if missing something. > > ``` > 1. get format from hiveConf > 2. get serde-lib in folowing order: > 1. get serde-lib from format if format supports serde-lib > 2. get serde-lib from `hive.serde.lib.class.name` in table options > 3. use default serde-lib from hiveConf > ``` > > and you should reuse the hiveConf in GravitinoHiveCatalog because this hive conf is initialized from the hive conf dir this may need refactor Hive properties converter since we couldn't use a single instance for now , this issue seems far complicated, do you still want to continue this PR or I could continue the PR based on your change. Hi @FANNG1, Thanks a lot for the detailed analysis and for pointing out the exact Flink logic this is very helpful. You’re right that SerDe resolution in Flink involves multiple layers (format, table options, and HiveConf defaults), and reusing the HiveConf from GravitinoHiveCatalog would likely require a broader refactor than this PR originally scoped for. I’m happy to let you continue the PR based on my changes if that makes it cleaner and easier to align with Flink’s behavior. Please feel free to adjust or refactor HivePropertiesConverter as needed. Thanks again for taking this forward, and I’m happy to review or help test any follow-up changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
