Copilot commented on code in PR #9590:
URL: https://github.com/apache/gravitino/pull/9590#discussion_r2676032020
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/jdbc/mysql/GravitinoMysqlJdbcCatalogFactory.java:
##########
@@ -31,7 +32,11 @@ public String gravitinoCatalogProvider() {
}
@Override
- public PropertiesConverter propertiesConverter() {
+ public CatalogPropertiesConverter catalogPropertiesConverter() {
+ return MysqlPropertiesConverter.INSTANCE;
+ }
+
Review Comment:
Missing @Override annotation. This method overrides the abstract method
defined in GravitinoJdbcCatalogFactory and should include the @Override
annotation for clarity and to catch potential issues if the parent method
signature changes.
```suggestion
@Override
```
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/jdbc/postgresql/GravitinoPostgresJdbcCatalogFactory.java:
##########
@@ -31,7 +32,11 @@ public String gravitinoCatalogProvider() {
}
@Override
- public PropertiesConverter propertiesConverter() {
+ public CatalogPropertiesConverter catalogPropertiesConverter() {
+ return PostgresqlPropertiesConverter.INSTANCE;
+ }
+
Review Comment:
Missing @Override annotation. This method overrides the abstract method
defined in GravitinoJdbcCatalogFactory and should include the @Override
annotation for clarity and to catch potential issues if the parent method
signature changes.
```suggestion
@Override
```
##########
flink-connector/flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/hive/FlinkHiveCatalogIT.java:
##########
@@ -100,6 +112,45 @@ protected void initDefaultHiveCatalog() {
ImmutableMap.of("metastore.uris", hiveMetastoreUri));
}
+ private void initHiveConfDir() {
+ if (hiveConfDir != null) {
+ return;
+ }
+ try {
+ java.nio.file.Path dir =
java.nio.file.Files.createTempDirectory("flink-hive-conf");
Review Comment:
Resource leak: The temporary directory created by Files.createTempDirectory
is never cleaned up. Consider adding cleanup logic in a teardown method (e.g.,
@AfterAll) to delete the temporary directory and its contents to prevent
accumulation of test artifacts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
