justinmclean commented on PR #10182: URL: https://github.com/apache/gravitino/pull/10182#issuecomment-3995607669
Looks good, but a few minor improvements needed: - Null-body fix in registerJobTemplate is incomplete; it can still trigger an unhandled NPE before try/catch - PR contains unrelated changes in TestCompactionStrategyHandler.java? - Minor style inconsistency in tests with FQN used inline -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
