shaojunying commented on PR #10182: URL: https://github.com/apache/gravitino/pull/10182#issuecomment-3998288794
Thanks for the review @justinmclean! Here's my plan for addressing your feedback: 1. **`registerJobTemplate` NPE in catch block**: Good catch — the `catch` block still dereferences `request.getJobTemplate().name()`, which can NPE if `getJobTemplate()` returns null (even after the null request body check). I'll fix this by moving the name extraction inside the `try` block or adding a safe fallback in the `catch` block. 2. **Unrelated `TestCompactionStrategyHandler.java` changes**: Will remove those from this PR. 3. **FQN style inconsistency in tests**: I noticed `TestSchemaOperations.java` uses `javax.ws.rs.client.Entity.entity(...)` inline instead of the imported `Entity`. Will fix this to be consistent with the other test files. I'll push the fixes shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
