FANNG1 commented on code in PR #10517:
URL: https://github.com/apache/gravitino/pull/10517#discussion_r2986864532
##########
flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/jdbc/GravitinoJdbcCatalogFactory.java:
##########
@@ -46,15 +47,25 @@ public org.apache.flink.table.catalog.Catalog
createCatalog(Context context) {
context.getOptions().remove(JdbcPropertiesConstants.FLINK_DRIVER);
final FactoryUtil.CatalogFactoryHelper helper =
FactoryUtils.createCatalogFactoryHelper(this, context);
+ helper.validate();
String defaultDatabase =
helper.getOptions().get(GravitinoJdbcCatalogFactoryOptions.DEFAULT_DATABASE);
Preconditions.checkArgument(
defaultDatabase != null,
GravitinoJdbcCatalogFactoryOptions.DEFAULT_DATABASE.key() + " should
not be null.");
- return new GravitinoJdbcCatalog(
+ return newCatalog(
context, defaultDatabase, schemaAndTablePropertiesConverter(),
partitionConverter());
}
+ protected org.apache.flink.table.catalog.Catalog newCatalog(
Review Comment:
rename org.apache.flink.table.catalog.Catalog to Catalog
##########
flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/jdbc/GravitinoJdbcCatalogFactory.java:
##########
@@ -46,15 +47,25 @@ public org.apache.flink.table.catalog.Catalog
createCatalog(Context context) {
context.getOptions().remove(JdbcPropertiesConstants.FLINK_DRIVER);
final FactoryUtil.CatalogFactoryHelper helper =
FactoryUtils.createCatalogFactoryHelper(this, context);
+ helper.validate();
Review Comment:
why add this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
