FANNG1 commented on code in PR #10517:
URL: https://github.com/apache/gravitino/pull/10517#discussion_r2987014831
##########
flink-connector/flink-common/src/test/java/org/apache/gravitino/flink/connector/integration/test/hive/FlinkHiveCatalogIT.java:
##########
@@ -198,6 +199,19 @@ private void initHiveConfDir() {
}
}
+ protected String getSharedHiveConfDir() {
+ try {
+ return java.nio.file.Paths.get(
Review Comment:
Fixed in b68f1e918. I changed this to use the imported `Paths` type.
##########
settings.gradle.kts:
##########
@@ -22,8 +22,9 @@ plugins {
rootProject.name = "gravitino"
-val scalaVersion: String =
gradle.startParameter.projectProperties["scalaVersion"]?.toString()
Review Comment:
I reverted the formatting-only part in b68f1e918. There was no need to keep
this stylistic change in the PR.
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/util/BaseIT.java:
##########
@@ -91,6 +91,10 @@ public class BaseIT {
private static final Logger LOG = LoggerFactory.getLogger(BaseIT.class);
private static final Splitter COMMA =
Splitter.on(",").omitEmptyStrings().trimResults();
+ private static final String LOOPBACK_HOST = "127.0.0.1";
Review Comment:
I kept the BaseIT normalization helper, but adjusted it in b68f1e918. We
still need to normalize wildcard bind addresses for test clients, but mapping
IPv6 `::` to `127.0.0.1` is not safe. I changed it to map `0.0.0.0 ->
127.0.0.1` and `:: -> ::1`, and updated the test accordingly.
##########
settings.gradle.kts:
##########
@@ -81,17 +86,28 @@ include(
include("spark-connector:spark-common")
if (scalaVersion == "2.12") {
// flink only support scala 2.12
- include("flink-connector:flink")
- include("flink-connector:flink-runtime")
+ include("flink-connector:flink-common")
+ include("flink-connector:flink-1.18", "flink-connector:flink-runtime-1.18")
+ project(":flink-connector:flink-1.18").projectDir =
file("flink-connector/v1.18/flink")
+ project(":flink-connector:flink-runtime-1.18").projectDir =
+ file("flink-connector/v1.18/flink-runtime")
}
include("spark-connector:spark-3.3", "spark-connector:spark-runtime-3.3")
project(":spark-connector:spark-3.3").projectDir =
file("spark-connector/v3.3/spark")
-project(":spark-connector:spark-runtime-3.3").projectDir =
file("spark-connector/v3.3/spark-runtime")
-include("spark-connector:spark-3.4", "spark-connector:spark-runtime-3.4",
"spark-connector:spark-3.5", "spark-connector:spark-runtime-3.5")
+project(":spark-connector:spark-runtime-3.3").projectDir =
Review Comment:
I kept this change. This include wiring is the actual semantic part of the
PR because the versioned Flink modules need to be added to the build. I only
reverted the unrelated formatting churn around it.
##########
settings.gradle.kts:
##########
@@ -67,7 +68,11 @@ include("iceberg:iceberg-common")
include("iceberg:iceberg-rest-server")
include("lance:lance-common")
include("lance:lance-rest-server")
-include("authorizations:authorization-ranger",
"authorizations:authorization-common", "authorizations:authorization-chain")
+include(
Review Comment:
I reverted this formatting-only change in b68f1e918 to keep the PR diff
focused.
##########
flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/utils/CatalogCompat.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.flink.connector.utils;
+
+import java.util.List;
+import java.util.Map;
+import org.apache.flink.table.api.Schema;
+import org.apache.flink.table.catalog.CatalogTable;
+import org.apache.flink.table.catalog.ResolvedCatalogTable;
+
+/** Typed compatibility hook that is implemented per Flink minor version. */
+public interface CatalogCompat {
+
+ CatalogTable createCatalogTable(
Review Comment:
Fixed in b68f1e918. I added method-level javadocs here to make the
compatibility contract clearer across versioned Flink modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
