bbiiaaoo commented on code in PR #10637:
URL: https://github.com/apache/gravitino/pull/10637#discussion_r3042613202
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceNamespaceOperations.java:
##########
@@ -66,6 +66,22 @@ public Response listNamespaces(
@DefaultValue(NAMESPACE_DELIMITER_DEFAULT) @QueryParam("delimiter")
String delimiter,
@QueryParam("page_token") String pageToken,
@QueryParam("limit") Integer limit) {
+ return listNamespacesInternal(namespaceId, delimiter, pageToken, limit);
+ }
+
+ @GET
+ @Path("/list")
+ @Timed(name = "list-namespaces-root." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "list-namespaces-root", absolute = true)
+ public Response listNamespacesOnRoot(
+ @DefaultValue(NAMESPACE_DELIMITER_DEFAULT) @QueryParam("delimiter")
String delimiter,
+ @QueryParam("page_token") String pageToken,
+ @QueryParam("limit") Integer limit) {
+ return listNamespacesInternal(delimiter, delimiter, pageToken, limit);
+ }
Review Comment:
Done
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceNamespaceOperations.java:
##########
@@ -84,6 +100,19 @@ public Response listNamespaces(
public Response describeNamespace(
@PathParam("id") String namespaceId,
@DefaultValue(NAMESPACE_DELIMITER_DEFAULT) @QueryParam("delimiter")
String delimiter) {
+ return describeNamespaceInternal(namespaceId, delimiter);
+ }
+
+ @POST
+ @Path("/describe")
+ @Timed(name = "describe-namespaces-root." +
MetricNames.HTTP_PROCESS_DURATION, absolute = true)
+ @ResponseMetered(name = "describe-namespaces-root", absolute = true)
+ public Response describeNamespaceOnRoot(
+ @DefaultValue(NAMESPACE_DELIMITER_DEFAULT) @QueryParam("delimiter")
String delimiter) {
+ return describeNamespaceInternal(delimiter, delimiter);
+ }
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
