bbiiaaoo commented on code in PR #10637:
URL: https://github.com/apache/gravitino/pull/10637#discussion_r3042699316
##########
lance/lance-rest-server/src/test/java/org/apache/gravitino/lance/service/rest/TestLanceNamespaceOperations.java:
##########
@@ -595,8 +583,7 @@ void testDeregisterTable() {
Mockito.reset(tableOps);
when(tableOps.deregisterTable(any(), any()))
.thenThrow(
- LanceNamespaceException.notFound(
- "Table not found", "NoSuchTableException", tableIds, ""));
+ new org.lance.namespace.errors.TableNotFoundException("Table not
found", "", tableIds));
resp =
Review Comment:
Fixed
##########
lance/lance-rest-server/src/test/java/org/apache/gravitino/lance/service/rest/TestLanceNamespaceOperations.java:
##########
@@ -644,14 +630,13 @@ void testDescribeTable() {
Assertions.assertEquals(MediaType.APPLICATION_JSON_TYPE,
resp.getMediaType());
DescribeTableResponse response =
resp.readEntity(DescribeTableResponse.class);
Assertions.assertEquals(createTableResponse.getLocation(),
response.getLocation());
- Assertions.assertEquals(createTableResponse.getProperties(),
response.getProperties());
+ Assertions.assertEquals(createTableResponse.getMetadata(),
response.getMetadata());
// Test not found exception
Mockito.reset(tableOps);
when(tableOps.describeTable(any(), any(), any()))
.thenThrow(
- LanceNamespaceException.notFound(
- "Table not found", "NoSuchTableException", tableIds, ""));
+ new org.lance.namespace.errors.TableNotFoundException("Table not
found", "", tableIds));
resp =
Review Comment:
Fixed
##########
lance/lance-rest-server/src/test/java/org/apache/gravitino/lance/service/rest/TestLanceNamespaceOperations.java:
##########
@@ -693,9 +677,7 @@ void testTableExists() {
Assertions.assertEquals(Response.Status.OK.getStatusCode(),
resp.getStatus());
// test throw exception
- doThrow(
- LanceNamespaceException.notFound(
- "Table not found", "NoSuchTableException", tableIds, ""))
+ doThrow(new org.lance.namespace.errors.TableNotFoundException("Table not
found", "", tableIds))
.when(tableOps)
.tableExists(any(), any());
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
