laserninja commented on code in PR #10673:
URL: https://github.com/apache/gravitino/pull/10673#discussion_r3067551176
##########
server-common/src/main/java/org/apache/gravitino/server/authentication/JwksTokenValidator.java:
##########
@@ -161,6 +163,12 @@ public Principal validateToken(String token, String
serviceAudience) {
}
return userPrincipal;
+ } catch (BadJWTException e) {
Review Comment:
ExpiredJWTException does not exist in nimbus-jose-jwt 9.37.3 (the version
Gravitino uses) as it was introduced in 10.x. Since upgrading nimbus is a
larger change, I've kept the BadJWTException catch with message checking and
added a comment explaining why. If/when Gravitino upgrades to nimbus 10.x, we
can switch to catching ExpiredJWTException directly. Let me know if you want me
to create another MR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
