roryqi commented on code in PR #10673:
URL: https://github.com/apache/gravitino/pull/10673#discussion_r3070696702
##########
server-common/src/main/java/org/apache/gravitino/server/authentication/JwksTokenValidator.java:
##########
@@ -161,6 +163,12 @@ public Principal validateToken(String token, String
serviceAudience) {
}
return userPrincipal;
+ } catch (BadJWTException e) {
Review Comment:
Why is upgrading nimbus is a large change? Maybe we can raise an another
pull request to upgrade nimbus. This seems a work around. We should avoid work
around fix as possible as we can.
##########
server-common/src/main/java/org/apache/gravitino/server/authentication/JwksTokenValidator.java:
##########
@@ -161,6 +163,12 @@ public Principal validateToken(String token, String
serviceAudience) {
}
return userPrincipal;
+ } catch (BadJWTException e) {
Review Comment:
Maybe we can raise an another pull request to upgrade nimbus. This seems a
work around. We should avoid work around fix as possible as we can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
