lasdf1234 commented on code in PR #11168:
URL: https://github.com/apache/gravitino/pull/11168#discussion_r3272814334
##########
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/TestIcebergExceptionMapper.java:
##########
@@ -48,7 +48,7 @@ private void checkExceptionStatus(Exception exception, int
statusCode) {
public void testIcebergExceptionMapper() {
checkExceptionStatus(new IllegalArgumentException(""), 400);
checkExceptionStatus(new ValidationException(""), 400);
- checkExceptionStatus(new NamespaceNotEmptyException(""), 400);
+ checkExceptionStatus(new NamespaceNotEmptyException(""), 409);
Review Comment:
For the Response.Status.* suggestions: this mapper and its tests
intentionally mirror Iceberg's RESTCatalogAdapter / existing Gravitino tests,
which use numeric status literals throughout. We only changed the mapping for
NamespaceNotEmptyException (400 → 409). Refactoring the entire map/test to
JAX-RS constants is out of scope for this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
