lasdf1234 commented on code in PR #11168:
URL: https://github.com/apache/gravitino/pull/11168#discussion_r3273044177
##########
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergNamespaceOperations.java:
##########
@@ -183,6 +183,13 @@ void testDropNamespace() {
verifyCreateNamespaceSucc(Namespace.of("drop_foo3", "a"));
verifyDropNamespaceFail(404, Namespace.of("drop_foo3", "b"));
verifyDropNamespaceSucc(Namespace.of("drop_foo3", "a"));
+
+ // drop non-empty namespace should return 409 Conflict per Iceberg REST
spec
+ String uniqueSuffix = String.valueOf(System.nanoTime());
+ Namespace nonEmptyNs = Namespace.of("drop_nonempty_foo_" + uniqueSuffix);
+ verifyCreateNamespaceSucc(nonEmptyNs);
+ verifyRegisterTableSucc("drop_nonempty_table_" + uniqueSuffix, nonEmptyNs);
Review Comment:
By adopting a different processing logic, it is possible to ensure that all
tables are deleted once the method is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
