lasdf1234 commented on code in PR #11219:
URL: https://github.com/apache/gravitino/pull/11219#discussion_r3322871752
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -528,6 +492,23 @@ public PlanTableScanResponse planTableScan(
}
}
+ /**
+ * Builds a synchronous COMPLETED scan plan response for Iceberg 1.11+ REST
clients only.
+ *
+ * <p>Matches {@link CatalogHandlers#planTableScan}: {@code file-scan-tasks}
plus {@code
+ * specs-by-id} from {@link Table#specs()}. Does not populate legacy {@code
plan-tasks} JSON
+ * strings.
+ */
+ @SuppressWarnings("deprecation")
+ private static PlanTableScanResponse buildCompletedPlanTableScanResponse(
+ Table table, List<FileScanTask> fileScanTasks) {
+ return PlanTableScanResponse.builder()
+ .withPlanStatus(PlanStatus.COMPLETED)
+ .withFileScanTasks(fileScanTasks)
+ .withSpecsById(table.specs())
Review Comment:
Thank you very much for your valuable suggestions.
I checked this — it's intentional to match Iceberg 1.11
CatalogHandlers#planTableScan, so specs-by-id comes from table.specs() rather
than only the specs referenced by the returned tasks.
I added Javadoc on buildCompletedPlanTableScanResponse so it's clear we
shouldn't revert to task-scoped specs without a deliberate reason.
##########
gradle/libs.versions.toml:
##########
@@ -64,8 +64,10 @@ commons-beanutils = "1.11.0"
commons-configuration1 = "1.6"
commons-dbcp2 = "2.11.0"
caffeine = "2.9.3"
-iceberg = '1.10.1' # used for Gravitino Iceberg catalog and Iceberg REST
service
-iceberg4connector = "1.6.1" # used for compile connectors like Spark, Flink,
etc
+iceberg = '1.11.0'
+iceberg4spark33 = "1.8.1"
Review Comment:
Thank you very much for your valuable suggestions.
Agred with you.I added class Javadoc on SparkIcebergCatalogRestBackendIT33
and SparkIcebergCatalogHiveBackendIT33 stating deploy-mode tests cover basic
catalog CRUD only, not file-scan-tasks or multi-level namespace behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
