lasdf1234 commented on code in PR #11219:
URL: https://github.com/apache/gravitino/pull/11219#discussion_r3322727225
##########
flink-connector/v1.18/flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/iceberg/FlinkIcebergRestCatalogIT118.java:
##########
@@ -19,4 +19,9 @@
package org.apache.gravitino.flink.connector.integration.test.iceberg;
+import org.junit.jupiter.api.condition.DisabledIf;
+
+// Flink 1.18 uses Iceberg 1.9.x; lakehouse-iceberg (1.11) runs in embedded
MiniGravitino in the
+// same JVM. Run REST-catalog Iceberg IT in deploy mode only.
+@DisabledIf("org.apache.gravitino.integration.test.util.ITUtils#isEmbedded")
public class FlinkIcebergRestCatalogIT118 extends FlinkIcebergRestCatalogIT {}
Review Comment:
The parent class already has @DisabledIf, so the child class can remove the
duplicate code. - This does not hold true in JUnit 5.
You can view this error message:
https://github.com/apache/gravitino/actions/runs/26623599920/job/78454988215
Nothing need to be change.
##########
flink-connector/v1.19/flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/iceberg/FlinkIcebergRestCatalogIT119.java:
##########
@@ -19,4 +19,9 @@
package org.apache.gravitino.flink.connector.integration.test.iceberg;
+import org.junit.jupiter.api.condition.DisabledIf;
+
+// Flink 1.19 uses Iceberg 1.10.x; lakehouse-iceberg (1.11) runs in embedded
MiniGravitino in the
+// same JVM. Run REST-catalog Iceberg IT in deploy mode only.
+@DisabledIf("org.apache.gravitino.integration.test.util.ITUtils#isEmbedded")
public class FlinkIcebergRestCatalogIT119 extends FlinkIcebergRestCatalogIT {}
Review Comment:
The parent class already has @DisabledIf, so the child class can remove the
duplicate code. - This does not hold true in JUnit 5.
You can view this error message:
https://github.com/apache/gravitino/actions/runs/26623599920/job/78454988215
Nothing need to be change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
