jiangxt2 commented on code in PR #12103:
URL: https://github.com/apache/gravitino/pull/12103#discussion_r3622670556
##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/DorisTablePropertiesMetadata.java:
##########
@@ -38,10 +45,37 @@ public class DorisTablePropertiesMetadata extends
JdbcTablePropertiesMetadata {
ImmutableList.of(
PropertyEntry.integerOptionalPropertyEntry(
REPLICATION_FACTOR,
- "The number of replications for the table. If not specified
and the number of backend server less than 3,"
- + " the default value will be used",
+ "The number of replications for the table. If not specified
and the number"
+ + " of backend server less than 3, the default value will
be used",
false /* immutable */,
DEFAULT_REPLICATION_FACTOR, /* default value */
+ false /* hidden */),
+ PropertyEntry.stringOptionalPropertyEntry(
+ COMPRESSION,
+ "The compression type for the table (ZSTD, LZ4, LZ4F, ZLIB)."
+ + " Deprecated as a table-level property in Doris 4.0+",
+ false /* immutable */,
Review Comment:
After verifying across Doris 1.2.2, 3.0.6.2, and 4.0.6, compression cannot
be changed via ALTER TABLE ... SET ("compression" = "...") — it throws Unknown
table property: [compression] on all three versions. Unlike ClickHouse where
compression is a column-level CODEC that can be altered via ALTER TABLE MODIFY
COLUMN, Doris compression is a table-level property that only takes effect at
CREATE TABLE time. I will update it to immutable = true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
