jiangxt2 commented on code in PR #12103:
URL: https://github.com/apache/gravitino/pull/12103#discussion_r3622695697
##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/DorisTablePropertiesMetadata.java:
##########
@@ -38,10 +45,37 @@ public class DorisTablePropertiesMetadata extends
JdbcTablePropertiesMetadata {
ImmutableList.of(
PropertyEntry.integerOptionalPropertyEntry(
REPLICATION_FACTOR,
- "The number of replications for the table. If not specified
and the number of backend server less than 3,"
- + " the default value will be used",
+ "The number of replications for the table. If not specified
and the number"
+ + " of backend server less than 3, the default value will
be used",
false /* immutable */,
DEFAULT_REPLICATION_FACTOR, /* default value */
+ false /* hidden */),
+ PropertyEntry.stringOptionalPropertyEntry(
+ COMPRESSION,
+ "The compression type for the table (ZSTD, LZ4, LZ4F, ZLIB)."
+ + " Deprecated as a table-level property in Doris 4.0+",
+ false /* immutable */,
+ null /* default value */,
+ false /* hidden */),
+ PropertyEntry.stringOptionalPropertyEntry(
+ BLOOM_FILTER_COLUMNS,
+ "Comma-separated list of columns for which bloom filter
indexes are created",
+ false /* immutable */,
+ null /* default value */,
+ false /* hidden */),
+ PropertyEntry.stringOptionalPropertyEntry(
+ STORAGE_POLICY,
+ "The name of the storage policy for cold-hot separation",
+ false /* immutable */,
+ null /* default value */,
+ false /* hidden */),
+ PropertyEntry.stringReservedPropertyEntry(
Review Comment:
You're right. They are user-configurable properties, not internal system
properties. I was over-cautious marking them reserved. I will promote them to
writable: enable_unique_key_merge_on_write as immutable = true (Doris rejects
ALTER), and light_schema_change as immutable = false (Doris allows ALTER via
SchemaChangeHandler).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
