diqiu50 commented on code in PR #12294: URL: https://github.com/apache/gravitino/pull/12294#discussion_r3713456156
########## catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/TrinoNativeViewCodec.java: ########## @@ -0,0 +1,435 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog.hive; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.node.ArrayNode; +import com.fasterxml.jackson.databind.node.ObjectNode; +import java.io.IOException; +import java.util.ArrayList; +import java.util.Base64; +import java.util.List; +import java.util.Locale; +import java.util.regex.Pattern; +import javax.annotation.Nullable; +import org.apache.gravitino.rel.types.Type; +import org.apache.gravitino.rel.types.Types; + +/** + * Encodes and decodes Trino/Presto's native "Presto View" HMS view format, so that views created by + * Gravitino's Trino dialect are readable by a native Trino Hive connector (and vice versa). + * + * <p>Trino recognizes a Hive Metastore VIRTUAL_VIEW table as a Trino view when it carries the + * {@code presto_view=true} table parameter and its {@code comment} table parameter equals {@code + * "Presto View"}; the view body is stored in {@code viewOriginalText} as {@code "/* Presto View: " + * + base64(json) + " * /"}. The JSON payload mirrors Trino's {@code ConnectorViewDefinition} wire Review Comment: No, this is a from-scratch implementation of the wire format, not copied from Trino's source — no io.trino.* imports, no dependency on Trino. The comments just document the format for interop purposes. I don't think it needs a LICENSE entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
