bbiiaaoo commented on PR #12383: URL: https://github.com/apache/gravitino/pull/12383#issuecomment-5251393237
Thanks @FANNG1 and @yuqi1129 for the suggestions. I have simplified and force-pushed the implementation based on the latest `main`. The updated implementation now: 1. Validates nullable, top-level, append-only `AddColumn` changes. 2. Hydrates declared or empty stored metadata before adding columns. 3. Batches the new fields into one `Dataset.addColumns` call. 4. Reuses `super.alterTable` to persist the requested columns and `lance.version`, and removes `lance.declared`. I removed the strict Gravitino-to-Arrow schema reconstruction and comparison, custom metadata CAS, manual `TableEntity` construction, and physical rollback logic. I agree that broader reconciliation from the Lance dataset back to Gravitino metadata should be handled in a separate PR, with Lance treated as the source of truth. Unit tests, the relevant integration tests, and the module check pass locally. Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
