bbiiaaoo commented on code in PR #12383:
URL: https://github.com/apache/gravitino/pull/12383#discussion_r3763319890
##########
catalogs/catalog-lakehouse-generic/src/test/java/org/apache/gravitino/catalog/lakehouse/lance/TestLanceTableOperations.java:
##########
@@ -473,6 +475,168 @@ public void testAlterTablePersistsUpdatedLanceVersion()
throws Exception {
Assertions.assertEquals("9",
storedTable.get().properties().get(LANCE_TABLE_VERSION));
}
+ @Test
+ public void testAlterTableAddsNullableColumnsInSingleLanceCommit() throws
Exception {
Review Comment:
I added a regression test for this failure window.
If the Lance add-columns commit succeeds but the Gravitino metadata update
fails, a subsequent load in VERSION_CHECK mode detects the changed Lance
version and refreshes both the schema and version from the underlying dataset.
Under the default DECLARED_AND_EMPTY mode, an existing non-empty stored
schema is not automatically reconciled. Broader reconciliation in that mode can
be addressed separately as part of the Lance-as-source-of-truth follow-up work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
