lasdf1234 commented on code in PR #12420:
URL: https://github.com/apache/gravitino/pull/12420#discussion_r3783555992
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -992,6 +1049,51 @@ public boolean dropCatalog(NameIdentifier ident, boolean
force)
});
}
+ /**
+ * Deletes write-through secrets for a schema and its fileset children using
properties snapped
+ * before the entities were dropped. Entity drop must succeed before calling
this.
+ */
+ private void deleteSecretsFromPropertySnapshots(
Review Comment:
1. The concern isn't sharing between schemas but liveness: the catch also
covers the code after s.createSchema() has already succeeded (isManagedEntity,
getHiddenPropertyNames), so a failure there deletes the secret while the schema
still exists in the underlying catalog holding that URN — suggest rolling back
only when the schema was not created.
It has been resolved. The solution is similar to that for the catalog.
2. schema.properties() is not read properties from entity store, some
catalog‘s properties does not contain URN
Read properties from SchemaEntity (entity store) before dropping
3. The logic is duplicate with SchemaOperationDispatcher.java
snapshotFilesetProperties and deleteSecretsAfterSchemaDrop
This method has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
