roryqi commented on code in PR #12420:
URL: https://github.com/apache/gravitino/pull/12420#discussion_r3794673761
##########
core/src/main/java/org/apache/gravitino/catalog/SchemaOperationDispatcher.java:
##########
@@ -327,10 +380,41 @@ public Schema alterSchema(NameIdentifier ident,
SchemaChange... changes)
@Override
public boolean dropSchema(NameIdentifier ident, boolean cascade) throws
NonEmptySchemaException {
NameIdentifier catalogIdent = getCatalogIdentifier(ident);
+
+ // Cascade: drop filesets via FilesetDispatcher first so each fileset
cleans its own
+ // write-through secrets. Do this before the catalog lock to avoid nested
TreeLocks.
+ if (cascade) {
Review Comment:
Why do u add this weird logic? Why do we need handle fileset logic here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
