lasdf1234 commented on PR #12725: URL: https://github.com/apache/gravitino/pull/12725#issuecomment-5463009214
Correction after review: - \`propertiesWithCredentialProviders()\` reads **entity** properties. With secret bindings those values are **URNs**, not plaintext. (\`conf\` is plaintext for connector \`ops()\` only — using \`conf\` here was wrong.) - Fix: keep reading entity, inject \`SecretManager\` on \`BaseCatalog\` via \`withSecretManager\`, and resolve URNs inside \`propertiesWithCredentialProviders()\` when \`secretManager != null\`. - \`catalogCredentialManager()\` stays unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
