lasdf1234 opened a new pull request, #12725:
URL: https://github.com/apache/gravitino/pull/12725
### What changes were proposed in this pull request?
Resolve secret URNs to plaintext when initializing
`CatalogCredentialManager` in
`BaseCatalog.catalogCredentialManager()`, so `getCredentials` /
`JdbcCredential`
(and other static-key providers) return usable plaintext instead of storage
URNs.
Add a unit test covering JDBC password URN resolution.
### Why are the changes needed?
Entity storage keeps secret-backed properties as URNs. `getSecrets` already
resolves them, but credential vending initialized providers from raw entity
props, so clients received URNs and standalone Iceberg REST JDBC auth failed.
Fix: #12724
### Does this PR introduce _any_ user-facing change?
Yes. `getCredentials` for secret-backed static credentials (e.g.
`jdbc-password`,
S3 secret keys) now returns plaintext instead of secret URNs. Storage /
getCatalog
masking (`******`) is unchanged.
### How was this patch tested?
- Unit: `TestBaseCatalogCredentialSecrets`
- Manual E2E: Vault KV entity secrets with Iceberg REST (aux + standalone)
and
Lance REST (aux + standalone); credentials API returns plaintext;
IRC/Lance OK
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
