lasdf1234 opened a new pull request, #12751:
URL: https://github.com/apache/gravitino/pull/12751

   ### What changes were proposed in this pull request?
   
   Refine the #12581 read-path behavior for entity properties:
   
   1. **Omit** metadata `reserved` + `hidden` keys (e.g. 
`gravitino.identifier`, `metalake-in-use`) from API responses.
   2. **Keep** masking editable hidden / secret properties as `******` for UI 
edit flows.
   3. Extract `PropertyResponsePolicy` and rename the apply helper to 
`HiddenPropertyMaskUtils.forApiResponse(...)`.
   4. Wire catalog/metalake/`EntityCombined*` paths through the policy; update 
unit tests.
   
   ### Why are the changes needed?
   
   `******` exists so clients can see that an editable secret is set. 
Reserved+hidden properties cannot be created or edited by users, so masking 
them adds noise without helping the UI.
   
   Fix: #12750
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Reserved+hidden properties (notably `gravitino.identifier`) are 
**omitted** from property maps again, instead of being returned as `******`. 
Editable hidden credentials remain `******`.
   
   ### How was this patch tested?
   
   ```bash
   ./gradlew :core:spotlessApply
   
   ./gradlew :core:test \
     --tests 'org.apache.gravitino.connector.TestHiddenPropertyMaskUtils' \
     --tests 'org.apache.gravitino.catalog.TestCatalogManager' \
     --tests 'org.apache.gravitino.meta.TestEntityCombinedObject' \
     --tests 'org.apache.gravitino.catalog.TestEntityCombinedFileset' \
     --tests 'org.apache.gravitino.catalog.TestTableOperationDispatcher' \
     --tests 'org.apache.gravitino.catalog.TestFilesetOperationDispatcher' \
     --tests 'org.apache.gravitino.catalog.TestSchemaOperationDispatcher' \
     --tests 'org.apache.gravitino.catalog.TestModelOperationDispatcher' \
     --tests 'org.apache.gravitino.metalake.TestMetalakeManager' \
     --tests 'org.apache.gravitino.metalake.TestMetalakeNormalizeDispatcher' \
     -PskipITs
   ```
   
   Made with [Cursor](https://cursor.com)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to