jerryshao commented on code in PR #12751:
URL: https://github.com/apache/gravitino/pull/12751#discussion_r3903763925


##########
core/src/main/java/org/apache/gravitino/catalog/EntityCombinedFileset.java:
##########
@@ -57,8 +59,16 @@ public static EntityCombinedFileset of(Fileset fileset) {
     return new EntityCombinedFileset(fileset, null);
   }
 
-  public EntityCombinedFileset withHiddenProperties(Set<String> 
hiddenProperties) {
-    this.hiddenProperties = hiddenProperties != null ? hiddenProperties : 
Collections.emptySet();
+  public EntityCombinedFileset withHiddenProperties(
+      Map.Entry<Set<String>, Set<String>> classified) {

Review Comment:
   Who is calling this method? I don't find any code invoke this method except 
the tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to