LuciferYang commented on PR #13233: URL: https://github.com/apache/gravitino/pull/13233#issuecomment-5698309787
Addressed in 955d0b0bb: added `@Nullable` to `isNone`'s parameter and moved the contract note into the interface Javadoc. On using `DistributionDTO.NONE` in the cross-representation test: `DistributionDTO` lives in the `common` module and `api` does not depend on `common` (it is the reverse), so referencing it from an `api` test would create a circular dependency. I kept a separate `Distribution` implementation with a comment explaining why. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
