yuqi1129 commented on code in PR #13233:
URL: https://github.com/apache/gravitino/pull/13233#discussion_r4048131518
##########
api/src/main/java/org/apache/gravitino/rel/expressions/distributions/Distributions.java:
##########
@@ -36,6 +37,20 @@ public class Distributions {
public static final Distribution NONE =
new DistributionImpl(Strategy.NONE, 0, Expression.EMPTY_EXPRESSION);
+ /**
+ * Returns true if the distribution is the NONE distribution. The comparison
is structural so both
+ * the built-in implementation and DTO representations of NONE match.
+ *
+ * @param distribution The distribution to check; may be null.
+ * @return true if the distribution is not null and represents the NONE
distribution.
+ */
+ public static boolean isNone(@Nullable Distribution distribution) {
+ return distribution != null
Review Comment:
Since `distribution` is nullable, if `distribution` is null, what's the
expected result of this method, I believe it should be `true`, but it's false
actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
