jiangxt2 commented on code in PR #13430:
URL: https://github.com/apache/gravitino/pull/13430#discussion_r4141028660
##########
clients/client-python/gravitino/dto/rel/indexes/json_serdes/index_serdes.py:
##########
@@ -51,5 +53,8 @@ def deserialize(cls, data: dict[str, Any]) -> Index:
index_type = Index.IndexType(data[cls.INDEX_TYPE].upper())
return IndexDTO(
- index_type, data.get(cls.INDEX_NAME), data[cls.INDEX_FIELD_NAMES]
+ index_type,
+ data.get(cls.INDEX_NAME),
+ data[cls.INDEX_FIELD_NAMES],
+ data.get("properties"),
Review Comment:
Updated Python IndexDTO equality and hashing to include index properties.
Added a regression test for vector indexes that differ only in
distance_function; the targeted TestIndexDTO suite passes (3 tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
