jiangxt2 commented on code in PR #13430: URL: https://github.com/apache/gravitino/pull/13430#discussion_r4141029482
########## docs/jdbc-clickhouse-catalog.md: ########## @@ -258,11 +260,18 @@ The `engine_parameters` property applies to `ReplacingMergeTree`, `SummingMergeT - `DATA_SKIPPING_SET` (default `GRANULARITY 1`, plus configurable `set(N)` max values) - `DATA_SKIPPING_NGRAMBFV1` (`GRANULARITY` customizable via `Index.properties()`, default 1; requires `ngram_size`, `bloom_filter_size`, `hash_functions`, `random_seed` in `Index.properties()`) - `DATA_SKIPPING_TOKENBFV1` (`GRANULARITY` customizable via `Index.properties()`, default 1; requires `bloom_filter_size`, `hash_functions`, `random_seed` in `Index.properties()`) + - `DATA_SKIPPING_VECTOR_SIMILARITY` (requires ClickHouse 25.8+; default `GRANULARITY 100000000`; requires `type=hnsw`, `distance_function`, and `dimensions` in `Index.properties()`) Review Comment: Updated the ClickHouse catalog guide to clarify that the Gravitino ALTER TABLE ADD INDEX path does not backfill existing data parts. It documents MATERIALIZE INDEX for existing data and notes that later background merges may materialize indexes, depending on ClickHouse settings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
