diqiu50 commented on code in PR #13600:
URL: https://github.com/apache/gravitino/pull/13600#discussion_r4215942356
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/utils/DataSourceUtils.java:
##########
@@ -153,10 +154,8 @@ private static DataSource createDBCPDataSource(JdbcConfig
jdbcConfig) throws Exc
basicDataSource.setPassword(password);
basicDataSource.setMaxTotal(jdbcConfig.getPoolMaxSize());
basicDataSource.setMinIdle(jdbcConfig.getPoolMinSize());
- // Set each time a connection is taken out from the connection pool, a
test statement will be
- // executed to confirm whether the connection is valid.
+ // Validate connections on borrow when enabled.
basicDataSource.setTestOnBorrow(jdbcConfig.getTestOnBorrow());
- basicDataSource.setValidationQuery(POOL_TEST_QUERY);
Review Comment:
After this change, we can no longer use SELECT 1 to validate MySQL
connections behind a proxy. Is there a better way to handle this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
