anilkumgopalap commented on code in PR #14862:
URL: https://github.com/apache/gravitino/pull/14862#discussion_r4567502377


##########
catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/generic/GenericCatalogOperations.java:
##########
@@ -218,19 +275,40 @@ public boolean dropSchema(NameIdentifier ident, boolean 
cascade) throws NonEmpty
           "Schema %s is not empty, cannot drop it without cascade", ident);
     }
 
+    TableLocationProvider provider = tableLocationProvider;
+    boolean schemaHooks = provider instanceof SupportsSchemaLocations;
+    Schema schema = null;
+    if (schemaHooks || tableIdents.length > 0) {
+      try {
+        schema = loadSchema(ident);
+      } catch (NoSuchSchemaException e) {
+        return false;

Review Comment:
   Agreed, reverted. A concurrent removal between listing and loading now 
propagates NoSuchSchemaException as before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to