anilkumgopalap commented on code in PR #14862:
URL: https://github.com/apache/gravitino/pull/14862#discussion_r4567529396


##########
catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/generic/GenericCatalogOperations.java:
##########
@@ -370,9 +448,15 @@ private boolean dropOrPurgeTable(NameIdentifier ident, 
boolean purge) {
    * @param ident the identifier of the table to drop
    * @param purge whether to purge the table instead of dropping it
    * @param schema the table's parent schema
+   * @param tablesWithRetainedData if not null, receives the identifier of the 
table when it is
+   *     dropped without its data being deleted
    * @return true if the table was dropped, false if it did not exist
    */
-  private boolean dropOrPurgeTable(NameIdentifier ident, boolean purge, Schema 
schema) {
+  private boolean dropOrPurgeTable(
+      NameIdentifier ident,
+      boolean purge,
+      Schema schema,
+      @Nullable List<NameIdentifier> tablesWithRetainedData) {

Review Comment:
   It collects the external tables the cascade dropped rather than purged. 
Their data is still under the schema location, and the list is passed to 
`unprovisionSchemaLocation` so the provider doesn't release storage that still 
holds data.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to