[
https://issues.apache.org/jira/browse/GUACAMOLE-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633940#comment-16633940
]
Nick Couchman commented on GUACAMOLE-637:
-----------------------------------------
[~TonyGeeUK] As with GUACAMOLE-638, we definitely appreciate the patch and
would love it if you'd be willing to do a pull request on the code and
contribute to the project! Overall contribution guidelines are here:
http://guacamole.apache.org/open-source/
Basically you'd just need to fork the code, create a branch for the changes,
make the changes, and then create a pull request. You'll want to make sure
that the Pull Request and commits follow the contribution guidelines (they
should reference this JIRA issue), and that the code style is consistent with
the style used throughout the project.
> Compile error: 'strncpy' output may be truncated copying 7 bytes from a
> string of length 7
> ------------------------------------------------------------------------------------------
>
> Key: GUACAMOLE-637
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-637
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Affects Versions: 1.0.0
> Environment: Fedora 28
> Reporter: Tony Gale
> Priority: Major
>
> Build error on Fedora 28:
> CC guac_svc/guacsvc_client_la-svc_service.lo
> guac_svc/svc_service.c: In function 'VirtualChannelEntry':
> guac_svc/svc_service.c:56:5: error: 'strncpy' output may be truncated copying
> 7 bytes from a string of length 7 [-Werror=stringop-truncation]
> strncpy(svc_plugin->plugin.channel_def.name, svc->name,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> GUAC_RDP_SVC_MAX_LENGTH);
> ~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
