Code0x58 commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-heron/pull/3669#discussion_r563189399
##########
File path: docker/dist/Dockerfile.dist.centos7
##########
@@ -34,14 +34,15 @@ RUN yum -y install epel-release \
ENV JAVA_HOME /usr/
-ADD artifacts /heron
+# run Heron installer
+RUN --mount=type=bind,source=artifacts,target=/tmp/heron
/tmp/heron/heron-install.sh && \
+ rm /usr/local/heron/dist/heron-core.tar.gz && \
+ rm -rf /opt/heron/heron-core/lib/scheduler/heron-local-scheduler.jar && \
+ rm -rf /opt/heron/heron-core/lib/scheduler/heron-mesos-scheduler.jar && \
+ rm -rf /opt/heron/heron-core/lib/scheduler/heron-slurm-scheduler.jar
Review comment:
Does this preclude the use of these images with anything other than
kubernetes? That's probably something to check with our other users via the
mailing list, just to make sure they're happy with it. At the same time, I'd
suggest going a step further and planning to flat out removing
mesos+slurm/anything other than local and k8s - if they're known to work as is,
it may not be worth the change though.
Is the local scheduler JAR costly? If not, it may be good to include in
images so people can use the images for testing and exploration.
:golfing:
```suggestion
rm
/opt/heron/heron-core/lib/scheduler/heron-{local,mesos,slurm}-scheduler.jar
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
