Code0x58 commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-heron/pull/3669#discussion_r563333165
##########
File path: docker/dist/Dockerfile.dist.centos7
##########
@@ -34,14 +34,15 @@ RUN yum -y install epel-release \
ENV JAVA_HOME /usr/
-ADD artifacts /heron
+# run Heron installer
+RUN --mount=type=bind,source=artifacts,target=/tmp/heron
/tmp/heron/heron-install.sh && \
+ rm /usr/local/heron/dist/heron-core.tar.gz && \
+ rm -rf /opt/heron/heron-core/lib/scheduler/heron-local-scheduler.jar && \
+ rm -rf /opt/heron/heron-core/lib/scheduler/heron-mesos-scheduler.jar && \
+ rm -rf /opt/heron/heron-core/lib/scheduler/heron-slurm-scheduler.jar
Review comment:
I imagine as a `.tar.gz` it isn't of use at runtime, so probably fair to
strip. I wouldn't be surprised if it's just an artefact that was packed into
`heron-install.sh` and it was just unpacked but not cleaned up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
