surahman opened a new pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710


   **_Issue #3707:_**
   
   A preliminary WIP PR to add Pod Template support in Heron similar to how it 
is handled in 
[Spark](https://spark.apache.org/docs/latest/running-on-kubernetes.html#pod-template).
 The `ConfigMap` name should be passed in from the cli flag `config-property`.
   
   The solution is following what has been done by 
[Spark](https://github.com/apache/spark/blob/de59e01aa4853ef951da080c0d1908d53d133ebe/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStep.scala#L39-L54)
 to produce the following YAML nodes:
   ```YAML
     volumes:
       - name: pod-template-name  # from <POD_TEMPLATE_VOLUME>.
         configMap:
           name: configmap-name  # from <configmapName>.
           items:
           - key: pod-template-key  # from <POD_TEMPLATE_KEY>.
             path: executor-pod-spec-template-file-name # from 
<EXECUTOR_POD_SPEC_TEMPLATE_FILE_NAME>.
   ```
   
   The first phase of this PR is generating the above basic YAML nodes in a 
`V1PodSpec`. The objective is to call the `createConfigMapVolumeMount` method 
from within `createStatefulSet` to add the `V1PodTemplateSpec` somewhere here:
   
https://github.com/apache/incubator-heron/blob/b2a4e828569c0445a758ca9f3780600a0855e665/heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/V1Controller.java#L386-L394
   
   Remaining on the TODO list is getting the `configmapName` from the cli as 
well as determining when an actual Pod Template has been supplied. The check 
for this will happen somewhere in the code block above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to