surahman edited a comment on pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-917798710


   @joshfischer1108 I have added some tests for the exposed code but the 
routines in the V1Controller are scoped to private. Testing these routines 
would mean having to make them protected and then exposing them using an 
accessor testing class that extends the V1Controller. I am not sure if changing 
the access level for the methods in V1Controller makes sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to