joshfischer1108 commented on pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-919135566


   > There are some issues with testing the `createStatefulSet` method in the 
`V1Controller`, namely with the private scope and an inability to mock it. It 
also performs some reads from the disk for files when it is setting up the 
Topology config. This requires mocking to simulate the disk reads, and there is 
no such functionality in place within the `ToplogyUtilsTest`s.
   > 
   > I have a WIP `testCreateStatefulSet` method setup but it seems like it 
might have to be removed along with a refactoring of everything else.
   
   Ok, let's create an issue around this and clean this up later.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to