surahman edited a comment on pull request #3741: URL: https://github.com/apache/incubator-heron/pull/3741#issuecomment-985626299
Thank you @nicknezis and @windhamwong for taking the time to test and review that PR 😄. I have pushed some fixes to the [documentation](https://github.com/apache/incubator-heron/blob/5068c79a9801e441e5420a9c99366561788304b2/website2/docs/schedulers-k8s-execution-environment.md) but the code remains unchanged. > If we want to lower the default Request/Limit values for the manager pod, we can always do that in a future PR. You would need a large and diverse dataset to form a baseline for the default resource values. I feel we would need to solicit statistics from users for topologies with varying configurations (bolts and spouts) as well as data velocity and volume to form a baseline. > just wondering if there is a better way to set the amount of memory? The reason I choose Megabytes is that we typically use Gigabytes for the units when working with memory (volatile and non-volatile) and we may need to work with fractions of a Gigabyte. I do not feel we would need the granularity of Kilobytes when working with memory and that it would make the command tedious to use (eg.: `1,000,000 KB` vs `1,000 MB` for 1 Gigabyte). That said, changing the units would not be difficult, it would mean one change in production code and a handful in the test suite. **_Edit:_** I think we are good to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
