n3nash commented on a change in pull request #631: Performing commit archiving in batches to avoid keeping a huge chunk in memory URL: https://github.com/apache/incubator-hudi/pull/631#discussion_r273732549
########## File path: hoodie-client/src/main/java/com/uber/hoodie/config/HoodieCompactionConfig.java ########## @@ -45,6 +45,7 @@ public static final String CLEANER_COMMITS_RETAINED_PROP = "hoodie.cleaner.commits.retained"; public static final String MAX_COMMITS_TO_KEEP = "hoodie.keep.max.commits"; public static final String MIN_COMMITS_TO_KEEP = "hoodie.keep.min.commits"; + public static final String COMMITS_ARCHIVAL_BATCH_SIZE_PROP = "hoodie.commits.archival.batch"; Review comment: Changing the config name is backwards incompatible change. Let me open another ticket to revisit and clean up configs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
