bvaradar commented on a change in pull request #623: Hudi Test Suite
URL: https://github.com/apache/incubator-hudi/pull/623#discussion_r275469850
 
 

 ##########
 File path: 
hoodie-bench/src/main/java/com/uber/hoodie/integrationsuite/validate/ValidateCount.java
 ##########
 @@ -0,0 +1,26 @@
+package com.uber.hoodie.integrationsuite.validate;
+
+import com.uber.hoodie.WriteStatus;
+import 
com.uber.hoodie.integrationsuite.job.HudiTestSuiteJob.HudiTestSuiteConfig;
+import org.apache.log4j.Logger;
+import org.apache.spark.api.java.JavaRDD;
+
+/**
+ * Any example implementation of validation
+ */
+public class ValidateCount implements IValidate<Long> {
+
+  private static Logger log = Logger.getLogger(ValidateCount.class);
+
+  @Override
+  public Long validate(HudiTestSuiteConfig cfg,
 
 Review comment:
   Since the test suite generates inserts/updates, is it possible to have a 
generic Count Validator implemented as part of this PR or next ? I think it is 
important from the usability perspective to have some default checks supported. 
 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to