vinothchandar commented on a change in pull request #600:  Timeline Service 
with Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r276487650
 
 

 ##########
 File path: 
hoodie-client/src/main/java/com/uber/hoodie/config/HoodieWriteConfig.java
 ##########
 @@ -71,9 +74,22 @@
   private static final String DEFAULT_FINALIZE_WRITE_PARALLELISM = 
DEFAULT_PARALLELISM;
   private static final String CONSISTENCY_CHECK_ENABLED = 
"hoodie.consistency.check.enabled";
   private static final String DEFAULT_CONSISTENCY_CHECK_ENABLED = "false";
+  private static final String NUM_FILE_STATUS_LISTER_THREADS = 
"hoodie.liststatus.maxthreads";
+  private static final Integer DEFAULT_NUM_FILE_STATUS_LISTER_THREADS = 8;
+  private static final String EMBEDDED_TIMELINE_SERVER_ENABLED = 
"hoodie.timeline.server.embedded";
+  private static final String DEFAULT_EMBEDDED_TIMELINE_SERVER_ENABLED = 
"false";
+
+  // Hoodie Write Client transparently rewrites File System View config when 
embedded mode is enabled
+  // We keep track of original config and rewritten config
+  private final FileSystemViewStorageConfig clientSpecifiedViewStorageConfig;
 
 Review comment:
   per discussion, if we make these immutable, then I am okay with keeping them 
here.. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to