vinothchandar commented on a change in pull request #623: Hudi Test Suite URL: https://github.com/apache/incubator-hudi/pull/623#discussion_r276870419
########## File path: hoodie-bench/src/main/java/com/uber/hoodie/integrationsuite/sink/KafkaWorkloadSink.java ########## @@ -0,0 +1,47 @@ +/* + * Copyright (c) 2019 Uber Technologies, Inc. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * + */ + +package com.uber.hoodie.integrationsuite.sink; + +import com.uber.hoodie.integrationsuite.sink.writer.KafkaSinkWriter; +import com.uber.hoodie.integrationsuite.sink.writer.WriteStats; +import java.io.IOException; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import org.apache.avro.generic.GenericRecord; + +/** + * Incomplete implementation of a {@link SinkType#KAFKA} to write to kafka topics + */ +public class KafkaWorkloadSink implements WorkloadSink<GenericRecord> { + + private KafkaSinkWriter<GenericRecord> sinkWriter; + + public KafkaWorkloadSink(KafkaSinkWriter<GenericRecord> sinkWriter) { Review comment: this seems unused? if you are not planning to implement kafka for now, can we remove these classes? IMO writing to dfs and then ingesting from that should be a good enough start.. this way we can focus more on workload generation and validation etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
