bvaradar commented on a change in pull request #600:  Timeline Service with 
Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r275540866
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieWriteClient.java
 ##########
 @@ -1190,8 +1177,8 @@ private void rollbackInflightCommits() {
     }
   }
 
-  private HoodieTable getTableAndInitCtx() {
-    // Create a Hoodie table which encapsulated the commits and files visible
+  private HoodieTable getTableAndInitCtx(JavaRDD<HoodieRecord<T>> records) {
+    startEmbeddedServerView(records.map(rec -> 
rec.getPartitionPath()).distinct().collect());
 
 Review comment:
   There is no need to support file-system view preloading and I have cleaned 
up the code. Timeline Server is started as part of constructor and this issue 
is no longer present.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to